[
https://issues.apache.org/jira/browse/BEAM-3818?focusedWorklogId=81413&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81413
]
ASF GitHub Bot logged work on BEAM-3818:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/18 22:33
Start Date: 16/Mar/18 22:33
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#4838: [BEAM-3818] Add support for streaming side inputs in the DirectRunner
URL: https://github.com/apache/beam/pull/4838#discussion_r175229449
##########
File path: sdks/python/apache_beam/runners/direct/evaluation_context.py
##########
@@ -99,6 +113,19 @@ def finalize_value_and_get_tasks(self, side_input):
view.has_result = True
return result
+ def update_watermarks_for_transform(self, ptransform, watermark):
+ # Collect tasks that get unblocked as the workflow progresses
+ unblocked_tasks = []
+ for view in self._transform_to_views[ptransform]:
+ unblocked_tasks.extend(self._update_watermarks_for_view(view, watermark))
+ return unblocked_tasks
+
+ def _update_watermarks_for_view(self, view, watermark):
+ unblocked_tasks = []
+ if watermark.input_watermark == WatermarkManager.WATERMARK_POS_INF:
Review comment:
Yes, this is part one of a refactor that will deliver the streaming side
input functionality. I've synced with Maria, and she has the other parts of
the refactor after this one goes in. Perhaps we should clarify the title of
the PR though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 81413)
Time Spent: 50m (was: 40m)
> Add support for the streaming side inputs in the Python DirectRunner
> --------------------------------------------------------------------
>
> Key: BEAM-3818
> URL: https://issues.apache.org/jira/browse/BEAM-3818
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: María GH
> Assignee: María GH
> Priority: Minor
> Fix For: 3.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The streaming DirectRunner should support streaming side input semantics.
> Currently, side inputs are only available for globally-windowed side input
> PCollections.
> Also, empty side inputs cause a pipeline stall.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
