[
https://issues.apache.org/jira/browse/BEAM-3818?focusedWorklogId=81484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81484
]
ASF GitHub Bot logged work on BEAM-3818:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/18 02:26
Start Date: 17/Mar/18 02:26
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #4838:
[BEAM-3818] Add support for streaming side inputs in the DirectRunner (part I:
update _SideInputsContainer as the watermark advances)
URL: https://github.com/apache/beam/pull/4838#discussion_r175245107
##########
File path: sdks/python/apache_beam/runners/direct/watermark_manager.py
##########
@@ -128,8 +129,9 @@ def _update_pending(self, input_committed_bundle,
applied_ptransform,
if input_committed_bundle and input_committed_bundle.has_elements():
completed_tw.remove_pending(input_committed_bundle)
- def _refresh_watermarks(self, applied_ptransform):
+ def _refresh_watermarks(self, applied_ptransform, side_inputs_container):
Review comment:
Similar to the above comment. Can you use self._side_inputs_container
instead of adding this new argument here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 81484)
Time Spent: 2.5h (was: 2h 20m)
> Add support for the streaming side inputs in the Python DirectRunner
> --------------------------------------------------------------------
>
> Key: BEAM-3818
> URL: https://issues.apache.org/jira/browse/BEAM-3818
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: María GH
> Assignee: María GH
> Priority: Minor
> Fix For: 3.0.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The streaming DirectRunner should support streaming side input semantics.
> Currently, side inputs are only available for globally-windowed side input
> PCollections.
> Also, empty side inputs cause a pipeline stall.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
