[
https://issues.apache.org/jira/browse/BEAM-3865?focusedWorklogId=81524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81524
]
ASF GitHub Bot logged work on BEAM-3865:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/18 07:49
Start Date: 17/Mar/18 07:49
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#4879: [BEAM-3865] Fix watermark hold handling bug.
URL: https://github.com/apache/beam/pull/4879#discussion_r175250980
##########
File path: sdks/python/apache_beam/transforms/trigger_test.py
##########
@@ -81,16 +84,8 @@ def bundle_data(data, size):
if not groupings:
groupings = [1]
+ grouping = list(groupings) + [-group_by for group_by in groupings]
Review comment:
What I mean is that the variable `grouping` (without "s" at the end) is
never used in the rest of the function. Is this a typo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 81524)
Time Spent: 1h (was: 50m)
> Incorrect timestamp on merging window outputs.
> ----------------------------------------------
>
> Key: BEAM-3865
> URL: https://issues.apache.org/jira/browse/BEAM-3865
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Robert Bradshaw
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Looks like we're setting multiple watermark holds with one arbitrarily being
> held.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
