[
https://issues.apache.org/jira/browse/BEAM-1251?focusedWorklogId=81681&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81681
]
ASF GitHub Bot logged work on BEAM-1251:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/18 18:54
Start Date: 18/Mar/18 18:54
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #4820:
[BEAM-1251] Upgrade from buffer to memoryview for Python 3
URL: https://github.com/apache/beam/pull/4820#discussion_r175299521
##########
File path: sdks/python/apache_beam/io/avroio.py
##########
@@ -309,8 +309,8 @@ def _decompress_bytes(data, codec):
# Compressed data includes a 4-byte CRC32 checksum which we verify.
# We take care to avoid extra copies of data while slicing large objects
- # by use of a buffer.
- result = snappy.decompress(buffer(data)[:-4])
Review comment:
Have you tested this change? When I ran it, it fails with: `TypeError:
argument 1 must be string or read-only buffer, not memoryview`.
This is because, a slice of a `buffer` will return the raw data, but in case
of `memoryview` a slice will return a `memoryview` object for that sub section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 81681)
Time Spent: 7.5h (was: 7h 20m)
> Python 3 Support
> ----------------
>
> Key: BEAM-1251
> URL: https://issues.apache.org/jira/browse/BEAM-1251
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Eyad Sibai
> Priority: Trivial
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> I have been trying to use google datalab with python3. As I see there are
> several packages that does not support python3 yet which google datalab
> depends on. This is one of them.
> https://github.com/GoogleCloudPlatform/DataflowPythonSDK/issues/6
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
