[ https://issues.apache.org/jira/browse/BEAM-3759?focusedWorklogId=82034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82034 ]
ASF GitHub Bot logged work on BEAM-3759: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/Mar/18 20:50 Start Date: 19/Mar/18 20:50 Worklog Time Spent: 10m Work Description: charlesccychen commented on issue #4763: [BEAM-3759] Add support for PaneInfo in WindowedValues URL: https://github.com/apache/beam/pull/4763#issuecomment-374370997 Thanks. The benchmarks seem very comparable. Without this change (at HEAD^): ``` [(1, 1.0581729412078857)] [(1, 1.0581729412078857), (1001, 1.0961029529571533)] [(1, 1.0581729412078857), (1001, 1.0961029529571533), (2001, 1.304905891418457)] [(1, 1.0581729412078857), (1001, 1.0961029529571533), (2001, 1.304905891418457), (3001, 1.3804380893707275)] [(1, 1.0581729412078857), (1001, 1.0961029529571533), (2001, 1.304905891418457), (3001, 1.3804380893707275), (4001, 1.6390268802642822)] Fixed cost 1.00637614384 Per-element 1.44604301453e-06 R^2 0.94447668637 ``` With this change: ``` [(1, 1.0614569187164307)] [(1, 1.0614569187164307), (1001, 1.1248741149902344)] [(1, 1.0614569187164307), (1001, 1.1248741149902344), (2001, 1.315816879272461)] [(1, 1.0614569187164307), (1001, 1.1248741149902344), (2001, 1.315816879272461), (3001, 1.3426880836486816)] [(1, 1.0614569187164307), (1001, 1.1248741149902344), (2001, 1.315816879272461), (3001, 1.3426880836486816), (4001, 1.6559441089630127)] Fixed cost 1.01865767245 Per-element 1.40678834915e-06 R^2 0.914786773244 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 82034) Time Spent: 3h 20m (was: 3h 10m) > Add support for PaneInfo descriptor in Python SDK > ------------------------------------------------- > > Key: BEAM-3759 > URL: https://issues.apache.org/jira/browse/BEAM-3759 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core > Affects Versions: 2.3.0 > Reporter: Charles Chen > Assignee: Charles Chen > Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > The PaneInfo descriptor allows a user to determine which particular > triggering emitted a value. This allows the user to differentiate between > speculative (early), on-time (at end of window) and late value emissions > coming out of a GroupByKey. We should add support for this feature in the > Python SDK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)