[
https://issues.apache.org/jira/browse/BEAM-3861?focusedWorklogId=82480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82480
]
ASF GitHub Bot logged work on BEAM-3861:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/18 21:00
Start Date: 20/Mar/18 21:00
Worklog Time Spent: 10m
Work Description: markflyhigh commented on a change in pull request
#4874: [BEAM-3861] Improve test infra in Python SDK for streaming end-to-end
test
URL: https://github.com/apache/beam/pull/4874#discussion_r175920707
##########
File path: sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
##########
@@ -46,10 +52,39 @@ def run_pipeline(self, pipeline):
print (
'Found: https://console.cloud.google.com/dataflow/jobsDetail'
'/locations/%s/jobs/%s?project=%s' % (region_id, job_id, project))
- self.result.wait_until_finish()
+
+ if not options.view_as(StandardOptions).streaming:
+ self.result.wait_until_finish()
+ else:
+ # TODO: Ideally, we want to wait until workers start successfully.
+ self.wait_until_running()
Review comment:
can you explain more about what other verification we can do here? Probably
good to do it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 82480)
Time Spent: 4h (was: 3h 50m)
> Build test infra for end-to-end streaming test in Python SDK
> ------------------------------------------------------------
>
> Key: BEAM-3861
> URL: https://issues.apache.org/jira/browse/BEAM-3861
> Project: Beam
> Issue Type: Task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
