[
https://issues.apache.org/jira/browse/BEAM-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409712#comment-16409712
]
Bill Neubauer commented on BEAM-3910:
-------------------------------------
That's correct. Simply adding float types to graphx/v1.proto would've been
sufficient. Since all primitive types in Go currently have an optimized
encoding, I wanted a plan to handle floats with the same degree of performance.
> Support floating point values in Go SDK
> ---------------------------------------
>
> Key: BEAM-3910
> URL: https://issues.apache.org/jira/browse/BEAM-3910
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Bill Neubauer
> Assignee: Bill Neubauer
> Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The Go SDK supports all the integer types of the language, but does not
> support floats.
> My plan for coding is to use the same technique the gob package uses, which
> results in a compact encoding for simple values.
> [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210]
> with rationale explained in
> https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details
> The resulting uint is then encoded using the existing coders in coderx.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
