[
https://issues.apache.org/jira/browse/BEAM-3706?focusedWorklogId=85353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-85353
]
ASF GitHub Bot logged work on BEAM-3706:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/18 19:16
Start Date: 28/Mar/18 19:16
Worklog Time Spent: 10m
Work Description: youngoli commented on issue #4924: [BEAM-3706] Removing
side inputs from CombinePayload proto.
URL: https://github.com/apache/beam/pull/4924#issuecomment-377003788
So the previous changes were actually breaking the DirectRunner because it
would translate a combine then immediately call getCombineFn on it. This worked
fine when all combines were translated with CombineFns, but now that combines
with side inputs aren't given CombineFns (or even Payloads) it was breaking. I
fixed that issue by making those getters return Optional<> where appropriate,
which should prevent further instances of assuming a CombineFn (or
CombinePayload) is present when it isn't.
@lukecwik
This change was a bit involved so please take another look at this PR if you
can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 85353)
Time Spent: 3h (was: 2h 50m)
> Update CombinePayload to improved model for Portability
> -------------------------------------------------------
>
> Key: BEAM-3706
> URL: https://issues.apache.org/jira/browse/BEAM-3706
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Labels: portability
> Time Spent: 3h
> Remaining Estimate: 0h
>
> This will mean changing the proto definition in beam_runner_api, most likely
> trimming out fields that are no longer necessary and adding any new ones that
> could be useful. The majority of work will probably be in investigating if
> some existing fields can actually be removed (SideInputs and Parameters for
> example).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
