[ 
https://issues.apache.org/jira/browse/BEAM-3848?focusedWorklogId=86364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86364
 ]

ASF GitHub Bot logged work on BEAM-3848:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/18 11:53
            Start Date: 01/Apr/18 11:53
    Worklog Time Spent: 10m 
      Work Description: timrobertson100 commented on issue #4905: [BEAM-3848] 
Enables ability to retry Solr writes on error (SolrIO)
URL: https://github.com/apache/beam/pull/4905#issuecomment-377781538
 
 
   @iemejia Please can you take a look?
   
   This now follows an approach similar to the `JdbcIO` testing. A 
`RetryPredicate` is used to determine if an exception is a candidate for 
retrying.  The predicate configuration is package private since it is only 
intended to enable testing with the embedded server instead of mocking.
   
   Please take a careful look at the exception handling in the test as I hit 
other issues with the DirectRunner and object leak tracking.
   
   Please note I changed the log implementation for tests to follow the same of 
the `JdbcIO` too.
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 86364)
    Time Spent: 5.5h  (was: 5h 20m)

> SolrIO: Improve retrying mechanism in client writes
> ---------------------------------------------------
>
>                 Key: BEAM-3848
>                 URL: https://issues.apache.org/jira/browse/BEAM-3848
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-solr
>    Affects Versions: 2.2.0, 2.3.0
>            Reporter: Tim Robertson
>            Assignee: Tim Robertson
>            Priority: Minor
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> A busy SOLR server is prone to return RemoteSOLRException on writing which 
> currently failsĀ a complete task (e.g. a partition of a spark RDD being 
> written to SOLR).
> A good addition would be the ability to provide a retrying mechanism for the 
> batch in flight, rather than failingĀ fast, which will most likely trigger a 
> much larger retry of more writes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to