[
https://issues.apache.org/jira/browse/BEAM-3437?focusedWorklogId=86478&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86478
]
ASF GitHub Bot logged work on BEAM-3437:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/18 05:08
Start Date: 02/Apr/18 05:08
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #4964:
[BEAM-3437] Introduce Schema class, and use it in BeamSQL
URL: https://github.com/apache/beam/pull/4964#discussion_r178487900
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/date/BeamSqlDatetimePlusExpressionTest.java
##########
@@ -44,14 +44,14 @@
private static final Row NULL_INPUT_ROW = null;
private static final BoundedWindow NULL_WINDOW = null;
- private static final Date DATE = str2DateTime("1984-04-19 01:02:03");
+ private static final DateTime DATE = str2DateTime("1984-04-19 01:02:03");
- private static final Date DATE_PLUS_15_SECONDS = new
DateTime(DATE).plusSeconds(15).toDate();
- private static final Date DATE_PLUS_10_MINUTES = new
DateTime(DATE).plusMinutes(10).toDate();
- private static final Date DATE_PLUS_7_HOURS = new
DateTime(DATE).plusHours(7).toDate();
- private static final Date DATE_PLUS_3_DAYS = new
DateTime(DATE).plusDays(3).toDate();
- private static final Date DATE_PLUS_2_MONTHS = new
DateTime(DATE).plusMonths(2).toDate();
- private static final Date DATE_PLUS_11_YEARS = new
DateTime(DATE).plusYears(11).toDate();
+ private static final DateTime DATE_PLUS_15_SECONDS = new
DateTime(DATE).plusSeconds(15);
Review comment:
<!--thread_id:cc_178340147_t;
commit:79c95678e593da730ba0472b77304ec1f916245e; resolved:1-->
<!--section:context-quote-->
> **akedin** wrote:
> `DATE_PLUS_15_SECONDS = DATE.plusSeconds()` should work
<!--section:body-->
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 86478)
Time Spent: 3h 10m (was: 3h)
> Support schema in PCollections
> ------------------------------
>
> Key: BEAM-3437
> URL: https://issues.apache.org/jira/browse/BEAM-3437
> Project: Beam
> Issue Type: Wish
> Components: beam-model
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> As discussed with some people in the team, it would be great to add schema
> support in {{PCollections}}. It will allow us:
> 1. To expect some data type in {{PTransforms}}
> 2. Improve some runners with additional features (I'm thinking about Spark
> runner with data frames for instance).
> A technical draft document has been created:
> https://docs.google.com/document/d/1tnG2DPHZYbsomvihIpXruUmQ12pHGK0QIvXS1FOTgRc/edit?disco=AAAABhykQIs&ts=5a203b46&usp=comment_email_document
> I also started a PoC on a branch, I will update this Jira with a "discussion"
> PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
