[
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=88409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88409
]
ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/18 12:00
Start Date: 06/Apr/18 12:00
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on issue #4990: [BEAM-3981]
[WIP] Futurize and fix python 2 compatibility for coders subpackage
URL: https://github.com/apache/beam/pull/4990#issuecomment-379232283
I've added some changes. Most notable:
- Replace bytes with memoryview in stream cython files. This also works with
subtypes of bytes like the future.builtins bytes type.
- Revert isinstance checks to typechecks for performance with the use of
past.builtins.
I've also added the applied approach to the [Python 3 proposal
document](https://docs.google.com/document/d/1xDG0MWVlDKDPu_IW9gtMvxi2S9I0GB0VDTkPhjXT0nE/edit).
It would be great to get some feedback on this so we can start moving forward
with the other subpackages.
@aaltay @charlesccychen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 88409)
Time Spent: 5.5h (was: 5h 20m)
> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
> Key: BEAM-3981
> URL: https://issues.apache.org/jira/browse/BEAM-3981
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix
> python 2 compatibility. This prepares the subpackage for python 3 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
