[
https://issues.apache.org/jira/browse/BEAM-3985?focusedWorklogId=88540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88540
]
ASF GitHub Bot logged work on BEAM-3985:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/18 18:06
Start Date: 06/Apr/18 18:06
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #412:
[BEAM-3985] Document Gradle commands for testing and linting.
URL: https://github.com/apache/beam-site/pull/412#discussion_r179834306
##########
File path: src/contribute/contribution-guide.md
##########
@@ -264,18 +276,9 @@ You can use following command to run a single test method.
$ python setup.py test -s <module>.<test class>.<test method>
-To Check for lint errors locally, install "tox" package and run following
-command.
-
- $ pip install tox
- $ tox -e lint_py2,lint_py3
-
-
-Beam supports running Python SDK tests using Maven. For this, navigate to root
-directory of your Apache Beam clone and execute following command. Currently
-this cannot be run from a virtual environment.
+To Check for lint errors locally, run the following command.
- $ mvn clean verify -pl sdks/python
+ $ ../../gradlew lint
Review comment:
Make it clear that ../.. is here because we assume it is being run from the
sdks/python directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 88540)
Time Spent: 0.5h (was: 20m)
> Update developer guide to reference new Python linting enviroments
> ------------------------------------------------------------------
>
> Key: BEAM-3985
> URL: https://issues.apache.org/jira/browse/BEAM-3985
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core, website
> Reporter: holdenk
> Assignee: Udi Meiri
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> tox.ini changed, but [https://beam.apache.org/contribute/contribution-guide/]
> still references the told envs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
