[ https://issues.apache.org/jira/browse/BEAM-3942?focusedWorklogId=89425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89425 ]
ASF GitHub Bot logged work on BEAM-3942: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/Apr/18 14:42 Start Date: 10/Apr/18 14:42 Worklog Time Spent: 10m Work Description: lgajowy commented on a change in pull request #5003: [BEAM-3942] Update performance testing framework to use Gradle URL: https://github.com/apache/beam/pull/5003#discussion_r180446905 ########## File path: build_rules.gradle ########## @@ -593,6 +593,118 @@ ext.applyJavaNature = { } } +// Reads and contains all necessary performance test parameters +class JavaPerformanceTestConfiguration { + String pkbLocation = System.getProperty('pkbLocation') + + String logLevel = System.getProperty('logLevel', 'INFO') + String gradleBinary = System.getProperty('gradleBinary', './gradlew') + String isOfficial = System.getProperty('official', 'true') + String benchmarks = System.getProperty('benchmarks', 'beam_integration_benchmark') + + String beamPrebuilt = System.getProperty('beamPrebuilt', 'true') + String beamSdk = System.getProperty('beamSdk', 'java') + + String timeout = System.getProperty('itTimeout', '1200') + + String kubeconfig = System.getProperty('kubeconfig', System.getProperty('user.home') + '/.kube/config') + String kubectl = System.getProperty('kubectl', 'kubectl') + + // PerfKit will have trouble reading 'null' path. It expects empty string if no scripts are expected. + String kubernetesScripts = System.getProperty('kubernetesScripts', '') + + String integrationTestPipelineOptions = System.getProperty('integrationTestPipelineOptions') + + // PerfKit will have trouble reading 'null' path. It expects empty string if no config file is expected. + String optionsConfigFile = System.getProperty('beamITOptions', '') + + String integrationTest = System.getProperty('integrationTest') + String itModule = System.getProperty('itModule') + + String runner = System.getProperty('integrationTestRunner', 'direct') + + String extraProperties = System.getProperty('beamExtraProperties', '') +} + +// Configures a project with a set of tasks needed for running performance tests +ext.enableJavaPerformanceTesting = { + println "enableJavaPerformanceTesting with ${it ? "$it" : "default configuration"} for project ${project.name}" + + // Use the implicit it parameter of the closure to handle zero argument or one argument map calls. + JavaPerformanceTestConfiguration configuration = it ? it as JavaPerformanceTestConfiguration : new JavaPerformanceTestConfiguration() + + // Add runners needed to run integration tests on + task packageIntegrationTests(type: Jar) { + if (gradle.startParameter.taskNames.contains('integrationTest')) { + + def runner = configuration.runner + dependencies { + if (runner.contains('dataflow')) { Review comment: It mimcs the maven behaviour that was there + is implemented in one generic place (code is not duplicated all over the build configurations as it was in maven). Because we don't have profiles in gradle, a system property was used to decide which runner to include - this is done by user by specifying `-DintegrationTestRunner=<runner_to_include>` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 89425) Time Spent: 5.5h (was: 5h 20m) > Update performance testing framework to use Gradle. > --------------------------------------------------- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing > Reporter: Chamikara Jayalath > Assignee: Ćukasz Gajowy > Priority: Major > Time Spent: 5.5h > Remaining Estimate: 0h > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)