[
https://issues.apache.org/jira/browse/BEAM-2990?focusedWorklogId=89882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89882
]
ASF GitHub Bot logged work on BEAM-2990:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/18 10:25
Start Date: 11/Apr/18 10:25
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #5079:
[BEAM-2990] support MAP in SQL schema
URL: https://github.com/apache/beam/pull/5079#discussion_r180705571
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -222,6 +224,9 @@ public boolean isDateType() {
public boolean isContainerType() {
Review comment:
<!--thread_id:cc_180488663_t;
commit:7bf9d2048e8d568ee9280629db391775cc490358; resolved:0-->
<!--section:context-quote-->
> **XuMingmin** wrote:
> while, my thought is MAP-> MAP, ARRAY -> CONTAINER, ROW -> COMPOSITE, to
make it clear for the backend types.
<!--section:body-->
I think it's actually just another type of container. i.e. one way of
imagining .a map is it's just a container of key-value pairs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 89882)
Time Spent: 2h 20m (was: 2h 10m)
> support data type MAP
> ---------------------
>
> Key: BEAM-2990
> URL: https://issues.apache.org/jira/browse/BEAM-2990
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> support Non-scalar types:
> MAP Collection of keys mapped to values
> ARRAY Ordered, contiguous collection that may contain duplicates
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
