[
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=90373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90373
]
ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/18 10:55
Start Date: 12/Apr/18 10:55
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#5053: [BEAM-3981] Futurize coders subpackage
URL: https://github.com/apache/beam/pull/5053#discussion_r181040977
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -304,7 +307,7 @@ def encode_to_stream(self, value, stream, nested):
dict_value = value # for typing
stream.write_byte(DICT_TYPE)
stream.write_var_int64(len(dict_value))
- for k, v in dict_value.iteritems():
+ for k, v in dict_value.items():
Review comment:
`iteritems()` isn't available anymore in Python 3. Instead, `items()`
returns an iterator. I've replaced it with `iteritems(dict)` from future.utils,
which returns an iterator on both versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 90373)
Time Spent: 8.5h (was: 8h 20m)
> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
> Key: BEAM-3981
> URL: https://issues.apache.org/jira/browse/BEAM-3981
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix
> python 2 compatibility. This prepares the subpackage for python 3 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
