[
https://issues.apache.org/jira/browse/BEAM-3942?focusedWorklogId=90418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90418
]
ASF GitHub Bot logged work on BEAM-3942:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/18 14:05
Start Date: 12/Apr/18 14:05
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #5003:
[BEAM-3942] Update performance testing framework to use Gradle
URL: https://github.com/apache/beam/pull/5003#discussion_r181093624
##########
File path: build_rules.gradle
##########
@@ -837,6 +837,154 @@ ext.applyJavaNature = {
}
}
+// Reads and contains all necessary performance test parameters
+class JavaPerformanceTestConfiguration {
+
+ /* Optional properties (set only if needed in your case): */
+
+ // Path to PerfKitBenchmarker application (pkb.py).
+ // It is only required when running Performance Tests with PerfKitBenchmarker
+ String pkbLocation = System.getProperty('pkbLocation')
+
+ // Data Processing Backend's log level.
+ String logLevel = System.getProperty('logLevel', 'INFO')
+
+ // Path to gradle binary.
+ String gradleBinary = System.getProperty('gradleBinary', './gradlew')
+
+ // If benchmark is official or not.
+ // Official benchmark results are meant to be displayed on PerfKitExplorer
dashboards.
+ String isOfficial = System.getProperty('official', 'false')
+
+ // Specifies names of benchmarks to be run by PerfKitBenchmarker.
+ String benchmarks = System.getProperty('benchmarks',
'beam_integration_benchmark')
+
+ // If beam is not "prebuilt" then PerfKitBenchmarker runs the build task
before running the tests.
+ String beamPrebuilt = System.getProperty('beamPrebuilt', 'true')
+
+ // Beam's sdk to be used by PerfKitBenchmarker.
+ String beamSdk = System.getProperty('beamSdk', 'java')
+
+ // Timeout (in seconds) after which PerfKitBenchmarker will stop executing
the benchmark (and will fail).
+ String timeout = System.getProperty('itTimeout', '1200')
+
+ // Path to kubernetes configuration file.
+ String kubeconfig = System.getProperty('kubeconfig',
System.getProperty('user.home') + '/.kube/config')
+
+ // Path to kubernetes executable.
+ String kubectl = System.getProperty('kubectl', 'kubectl')
+
+ // Paths to files with kubernetes infrastructure to setup before the test
runs.
+ // PerfKitBenchmarker will have trouble reading 'null' path. It expects
empty string if no scripts are expected.
+ String kubernetesScripts = System.getProperty('kubernetesScripts', '')
+
+ // Path to file with 'dynamic' and 'static' pipeline options.
+ // that will be appended by PerfKitBenchmarker to the test running command.
+ // PerfKitBenchmarker will have trouble reading 'null' path. It expects
empty string if no config file is expected.
+ String optionsConfigFile = System.getProperty('beamITOptions', '')
+
+ // Any additional properties to be appended to benchmark execution command.
+ String extraProperties = System.getProperty('beamExtraProperties', '')
+
+ // Runner which will be used for running the tests.
+ String runner = System.getProperty('integrationTestRunner', 'direct')
+
+ /* Always required properties: */
+
+ // Pipeline options to be used by the tested pipeline.
+ String integrationTestPipelineOptions =
System.getProperty('integrationTestPipelineOptions')
Review comment:
I think, unfortunately I've made a mistake here: we shouldn't set default
value of this property. This will result in adding direct runner as a
dependency everytime building is run (even if we are not running the
integrationTest task). Sorry for that!
A solution would be to not set the default value - the dependency won't be
included when there is no runner to attach. This property would then be "always
required" WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 90418)
Time Spent: 9h 20m (was: 9h 10m)
> Update performance testing framework to use Gradle.
> ---------------------------------------------------
>
> Key: BEAM-3942
> URL: https://issues.apache.org/jira/browse/BEAM-3942
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Chamikara Jayalath
> Assignee: Łukasz Gajowy
> Priority: Major
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> This requires performing updates to PerfKitBenchmarker and Beam so that we
> can execute performance tests using Gradle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
