[ https://issues.apache.org/jira/browse/BEAM-4069?focusedWorklogId=90916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90916 ]
ASF GitHub Bot logged work on BEAM-4069: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Apr/18 18:11 Start Date: 13/Apr/18 18:11 Worklog Time Spent: 10m Work Description: bsidhom opened a new pull request #5126: [BEAM-4069] Gracefully deserialize empty options structs URL: https://github.com/apache/beam/pull/5126 ------------------------ Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand: - [ ] What the pull request does - [ ] Why it does it - [ ] How it does it - [ ] Why this approach - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 90916) Time Spent: 10m Remaining Estimate: 0h > Empty pipeline options can be gracefully serialized/deserialized > ---------------------------------------------------------------- > > Key: BEAM-4069 > URL: https://issues.apache.org/jira/browse/BEAM-4069 > Project: Beam > Issue Type: Bug > Components: runner-core > Reporter: Ben Sidhom > Assignee: Ben Sidhom > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > PipelineOptionsTranslation.fromProto currently crashes with a > NullPointerException when passed an empty options Struct. This is due to > ProxyInvocationHandler.Deserializer expecting a non-empty enclosing Struct. > Empty pipeline options may be passed by SDKs interacting with a job server, > so this case needs to be handled. Note that testing a round-trip of an > effectively-empty Java PipelineOptions object is not sufficient to catch this > because "empty" Java options still contain default fields not defined in > other SDKs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)