[ https://issues.apache.org/jira/browse/BEAM-4038?focusedWorklogId=91844&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91844 ]
ASF GitHub Bot logged work on BEAM-4038: ---------------------------------------- Author: ASF GitHub Bot Created on: 17/Apr/18 17:21 Start Date: 17/Apr/18 17:21 Worklog Time Spent: 10m Work Description: rangadi commented on a change in pull request #5111: [BEAM-4038] Support Kafka Headers in KafkaIO URL: https://github.com/apache/beam/pull/5111#discussion_r182157943 ########## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaRecord.java ########## @@ -90,7 +98,7 @@ public KafkaTimestampType getTimestampType() { @Override public int hashCode() { - return Arrays.deepHashCode(new Object[]{topic, partition, offset, timestamp, kv}); + return Arrays.deepHashCode(new Object[] {topic, partition, offset, timestamp, headers, kv}); Review comment: Please check javadoc for `deepHashCode`() to make sure null is ok (mostly yes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 91844) Time Spent: 3.5h (was: 3h 20m) > Support Kafka Headers in KafkaIO > -------------------------------- > > Key: BEAM-4038 > URL: https://issues.apache.org/jira/browse/BEAM-4038 > Project: Beam > Issue Type: New Feature > Components: io-java-kafka > Reporter: Geet Kumar > Assignee: Raghu Angadi > Priority: Minor > Time Spent: 3.5h > Remaining Estimate: 0h > > Headers have been added to Kafka Consumer/Producer records (KAFKA-4208). The > purpose of this JIRA is to support this feature in KafkaIO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)