[
https://issues.apache.org/jira/browse/BEAM-4097?focusedWorklogId=94445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-94445
]
ASF GitHub Bot logged work on BEAM-4097:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/18 03:55
Start Date: 24/Apr/18 03:55
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #5191:
[BEAM-4097] Set environment for Python sdk function specs.
URL: https://github.com/apache/beam/pull/5191#discussion_r183599178
##########
File path:
sdks/python/apache_beam/runners/portability/universal_local_runner.py
##########
@@ -83,6 +86,16 @@ def cleanup(self):
time.sleep(0.1)
self._subprocess = None
+ @staticmethod
+ def default_docker_image():
+ if 'USER' in os.environ:
+ # Perhaps also test if this was built?
+ logging.info('Using latest built Python SDK docker image.')
+ return os.environ['USER'] +
'-docker.apache.bintray.io/beam/python:latest'
+ else:
+ logging.warnign('Could not find a Python SDK docker image.')
Review comment:
USER is not set in the jenkins environment; when have enough for a full
end-to-end test we may need to pass the appropriate path manually (which is
probably better anyway...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 94445)
Time Spent: 2.5h (was: 2h 20m)
> Python SDK should set the environment in the job submission protos
> ------------------------------------------------------------------
>
> Key: BEAM-4097
> URL: https://issues.apache.org/jira/browse/BEAM-4097
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
