[
https://issues.apache.org/jira/browse/BEAM-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454190#comment-16454190
]
Etienne Chauchot commented on BEAM-4088:
----------------------------------------
After some investigations, it appears to be a timing problem in the test. If we
bloc until the end of the threads in metricsExecutorService before the
ThreadLeakTracker rule is exectuted, then the test passes in gradle (no leaks
detected). I guess we were lucky with the other build runs that the threads had
time to finish before the rule gets executed.
I also added a blackbox test with a real pipeline with a metrics DoFn and it
passes with no leaks with Romain's fix.
Finally I ran these 2 tests on the actual master without Romain's fix and they
fail.
So I'll update Romain's PR and merge it.
> ExecutorServiceParallelExecutorTest#ensureMetricsThreadDoesntLeak in PR #4965
> does not pass in gradle
> -----------------------------------------------------------------------------------------------------
>
> Key: BEAM-4088
> URL: https://issues.apache.org/jira/browse/BEAM-4088
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
>
> This is a new test being added to ensure threads don't leak. The failure
> seems to indicate that threads do leak.
> This test fails using gradle but previously passed using maven
> PR: https://github.com/apache/beam/pull/4965
> Presubmit Failure:
> * https://builds.apache.org/job/beam_PreCommit_Java_GradleBuild/4059/
> *
> https://scans.gradle.com/s/grha56432j3t2/tests/jqhvlvf72f7pg-ipde5etqqejoa?openStackTraces=WzBd
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
