[ https://issues.apache.org/jira/browse/BEAM-3303?focusedWorklogId=95752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-95752 ]
ASF GitHub Bot logged work on BEAM-3303: ---------------------------------------- Author: ASF GitHub Bot Created on: 26/Apr/18 22:10 Start Date: 26/Apr/18 22:10 Worklog Time Spent: 10m Work Description: herohde commented on a change in pull request #5179: [BEAM-3303] Add Go Windowing support URL: https://github.com/apache/beam/pull/5179#discussion_r184545647 ########## File path: sdks/go/pkg/beam/core/runtime/graphx/serialize.go ########## @@ -942,28 +982,28 @@ func isCoGBKList(ref *CoderRef) ([]*CoderRef, bool) { return ref2.Components, true } -// TODO(wcn): Windowing information isn't currently propagated through -// our code. These methods will be used by other packages, so exporting -// them now. - // encodeWindow translates the preprocessed representation of a Beam coder // into the wire representation, capturing the underlying types used by // the coder. -func encodeWindow(w *window.Window) (*CoderRef, error) { - switch w.Kind() { - case window.GlobalWindow: +func encodeWindowCoder(w *coder.WindowCoder) (*CoderRef, error) { + switch w.Kind { + case coder.GlobalWindow: return &CoderRef{Type: GlobalWindowType}, nil + case coder.IntervalWindow: + return &CoderRef{Type: IntervalWindowType}, nil default: - return nil, fmt.Errorf("bad window kind: %v", w.Kind()) + return nil, fmt.Errorf("bad window kind: %v", w.Kind) } } // decodeWindow receives the wire representation of a Beam coder, extracting Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 95752) Time Spent: 5h 10m (was: 5h) > Go windowing support > -------------------- > > Key: BEAM-3303 > URL: https://issues.apache.org/jira/browse/BEAM-3303 > Project: Beam > Issue Type: Improvement > Components: sdk-go > Reporter: Henning Rohde > Assignee: Henning Rohde > Priority: Major > Time Spent: 5h 10m > Remaining Estimate: 0h > > Add support for Window.into and windowing strategies on Node. Implement the > various windowing strategies Beam has: GlobalWindow, FixedWindows, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)