[
https://issues.apache.org/jira/browse/BEAM-4131?focusedWorklogId=96867&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-96867
]
ASF GitHub Bot logged work on BEAM-4131:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/18 22:36
Start Date: 30/Apr/18 22:36
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #5233:
[BEAM-4131] Include SDK into Python SDK harness container.
URL: https://github.com/apache/beam/pull/5233#discussion_r185129837
##########
File path: sdks/python/container/build.gradle
##########
@@ -27,13 +27,26 @@ description = "Apache Beam :: SDKs :: Python :: Container"
// "./github.com/apache/beam/sdks/go"
resolveBuildDependencies.dependsOn ":beam-sdks-go:build"
+configurations {
+ dockerDependency
+}
+
dependencies {
golang {
// TODO(herohde): use "./" prefix to prevent gogradle use base github
path, for now.
// TODO(herohde): get the pkg subdirectory only, if possible. We spend
mins pulling cmd/beamctl deps.
build name: './github.com/apache/beam/sdks/go', dir:
project(':beam-sdks-go').projectDir
test name: './github.com/apache/beam/sdks/go', dir:
project(':beam-sdks-go').projectDir
}
+
+ dockerDependency project(path: ":beam-sdks-python", configuration:
"distConfig")
+}
+
+task copyDockerfileDependencies(type: Copy) {
+ from configurations.dockerDependency
+ rename "apache-beam.*\\.tar.gz", "apache-beam.tar.gz"
Review comment:
Indeed, after this PR it does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 96867)
Time Spent: 2h 20m (was: 2h 10m)
> Python SDK harness container image contains SDK and dependencies
> ----------------------------------------------------------------
>
> Key: BEAM-4131
> URL: https://issues.apache.org/jira/browse/BEAM-4131
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Ben Sidhom
> Assignee: Thomas Weise
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The Docker image for the SDK harness should contain SDK code and dependencies
> so that this does not need to be downloaded from the artifact retrieval
> service at each boot.
> This is required for operation with portable runners right now because the
> python client does not currently stage the SDK itself (as it does with the
> Dataflow runner).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
