[ 
https://issues.apache.org/jira/browse/BEAM-4196?focusedWorklogId=98102&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98102
 ]

ASF GitHub Bot logged work on BEAM-4196:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/18 02:42
            Start Date: 04/May/18 02:42
    Worklog Time Spent: 10m 
      Work Description: apilloud commented on a change in pull request #5276: 
[BEAM-4196][SQL] Support complex types in DDL
URL: https://github.com/apache/beam/pull/5276#discussion_r185980780
 
 

 ##########
 File path: 
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/parser/SqlDdlNodes.java
 ##########
 @@ -28,14 +27,6 @@
 public class SqlDdlNodes {
   private SqlDdlNodes() {}
 
-  /** Creates a CREATE TABLE. */
 
 Review comment:
   This annoys me. I don't like this extra indirection in calcite but I also 
don't like deviating from calcite unnecessaraly. Not much you can do about that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 98102)
    Time Spent: 0.5h  (was: 20m)

> [SQL] Support Complex Types in DDL
> ----------------------------------
>
>                 Key: BEAM-4196
>                 URL: https://issues.apache.org/jira/browse/BEAM-4196
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Anton Kedin
>            Assignee: Anton Kedin
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Neither our DDL parser we copied from calcite-server or the calcite-server 
> don't support complex types in DDL. If we want to model something like JSON 
> objects we need to support at least Arrays and nested Rows.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to