[
https://issues.apache.org/jira/browse/BEAM-3883?focusedWorklogId=100272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-100272
]
ASF GitHub Bot logged work on BEAM-3883:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/18 21:49
Start Date: 09/May/18 21:49
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #5251:
[BEAM-3883] Refactor and clean dependency.py to make it reusable with artifact
service
URL: https://github.com/apache/beam/pull/5251#discussion_r187132957
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/dependency.py
##########
@@ -604,68 +247,14 @@ def get_sdk_name_and_version():
return (BEAM_SDK_NAME, beam_version.__version__)
-def get_sdk_package_name():
- """For internal use only; no backwards-compatibility guarantees.
-
- Returns the PyPI package name to be staged to Google Cloud Dataflow."""
- sdk_name, _ = get_sdk_name_and_version()
- if sdk_name == GOOGLE_SDK_NAME:
- return GOOGLE_PACKAGE_NAME
- else:
- return BEAM_PACKAGE_NAME
+class DataFlowStager(stager.Stager):
Review comment:
Copied from above:
DataflowFileStager also overwrites get_sdk_package_name as for dataflow,
package can be GOOGLE_SDK_NAME hence we neet ro create a new sub class.
We can do method rewrite in an object instance but it seems hacky and right
way should be to create a subclass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 100272)
Time Spent: 4h 10m (was: 4h)
> Python SDK stages artifacts when talking to job server
> ------------------------------------------------------
>
> Key: BEAM-3883
> URL: https://issues.apache.org/jira/browse/BEAM-3883
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ben Sidhom
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> The Python SDK does not currently stage its user-defined functions or
> dependencies when talking to the job API. Artifacts that need to be staged
> include the user code itself, any SDK components not included in the
> container image, and the list of Python packages that must be installed at
> runtime.
>
> Artifacts that are currently expected can be found in the harness boot code:
> [https://github.com/apache/beam/blob/58e3b06bee7378d2d8db1c8dd534b415864f63e1/sdks/python/container/boot.go#L52.]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
