[
https://issues.apache.org/jira/browse/BEAM-3813?focusedWorklogId=102259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102259
]
ASF GitHub Bot logged work on BEAM-3813:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/18 19:37
Start Date: 15/May/18 19:37
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5244:
[BEAM-3813] Support encryption for S3FileSystem (SSE-S3, SSE-C and SSE-KMS)
URL: https://github.com/apache/beam/pull/5244#discussion_r188411159
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/S3Options.java
##########
@@ -33,13 +37,44 @@
@Description(
"Size of S3 upload chunks; max upload object size is this value
multiplied by 10000;"
- + "default is 64MB, or 5MB in memory-constrained environments")
- @Nullable
+ + "default is 64MB, or 5MB in memory-constrained environments. Must
be at least 5MB.")
+ @Default.InstanceFactory(S3UploadBufferSizeBytesFactory.class)
Integer getS3UploadBufferSizeBytes();
+
void setS3UploadBufferSizeBytes(Integer value);
@Description("Thread pool size, limiting max concurrent S3 operations")
@Default.Integer(50)
int getS3ThreadPoolSize();
void setS3ThreadPoolSize(int value);
+
+ @Description("Algorithm for SSE-S3 encryption, e.g. AES256.")
+ @Nullable
+ String getSSEAlgorithm();
+ void setSSEAlgorithm(String value);
+
+ @Description("SSE key for SSE-C encryption, e.g. a base64 encoded key and
the algorithm.")
+ @Nullable
+ SSECustomerKey getSSECustomerKey();
Review comment:
Hi, thanks you have a really valid argument. I hesitated to put the
arguments as Strings and build the API objects internally but I thought letting
the AWS SDK exposed would move this maintenance to the user. Do you have any
suggestion on how to do this properly ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 102259)
Time Spent: 1h 50m (was: 1h 40m)
> Support encryption for S3FileSystem (SSE-S3, SSE-C and SSE-KMS)
> ---------------------------------------------------------------
>
> Key: BEAM-3813
> URL: https://issues.apache.org/jira/browse/BEAM-3813
> Project: Beam
> Issue Type: Improvement
> Components: io-java-aws
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.5.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We should enable AWS S3 users to use encryption when reading or writing by
> provide encryption keys or using server side encryption via an algorithm, or
> a key management system (KMS)..
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
