[ https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=102672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102672 ]
ASF GitHub Bot logged work on BEAM-3981: ---------------------------------------- Author: ASF GitHub Bot Created on: 16/May/18 21:35 Start Date: 16/May/18 21:35 Worklog Time Spent: 10m Work Description: RobbeSneyders commented on a change in pull request #5053: [BEAM-3981] Futurize coders subpackage URL: https://github.com/apache/beam/pull/5053#discussion_r188780116 ########## File path: sdks/python/apache_beam/coders/coders.py ########## @@ -210,11 +216,15 @@ def as_cloud_object(self): def __repr__(self): return self.__class__.__name__ + # pylint: disable=protected-access def __eq__(self, other): - # pylint: disable=protected-access return (self.__class__ == other.__class__ and self._dict_without_impl() == other._dict_without_impl()) - # pylint: enable=protected-access + + def __hash__(self): Review comment: We can also explicitly implement the default python 2 hash, which is guaranteed to stay the same for an object: `hash(id(self))` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 102672) Time Spent: 18h 40m (was: 18.5h) > Futurize and fix python 2 compatibility for coders package > ---------------------------------------------------------- > > Key: BEAM-3981 > URL: https://issues.apache.org/jira/browse/BEAM-3981 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Robbe > Assignee: Robbe > Priority: Major > Fix For: Not applicable > > Time Spent: 18h 40m > Remaining Estimate: 0h > > Run automatic conversion with futurize tool on coders subpackage and fix > python 2 compatibility. This prepares the subpackage for python 3 support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)