[
https://issues.apache.org/jira/browse/BEAM-3999?focusedWorklogId=103027&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-103027
]
ASF GitHub Bot logged work on BEAM-3999:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/18 18:14
Start Date: 17/May/18 18:14
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5334:
[BEAM-3999] Futurize internal subpackage
URL: https://github.com/apache/beam/pull/5334#discussion_r189053386
##########
File path: sdks/python/apache_beam/internal/util.py
##########
@@ -20,9 +20,13 @@
For internal use only. No backwards compatibility guarantees.
"""
+from __future__ import absolute_import
+
import logging
import threading
import weakref
+from builtins import next
Review comment:
Hm... the change is harmless, I totally don't mind it. I am a little
concerned that we might not be able to enforce consistency in the codebase, and
automatically catch when such changes are required. Say, tomorrow somebody adds
a usage of `next` in against an object passed into the method, and we can't
tell if the object will has the iterator implemented in Py3-compliant way, so
then there would be a difference in behavior between py2 and py3, and importing
`next` would make a difference, but if linter does not catch it, chances are
reviewers won't notice it either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 103027)
Time Spent: 2h 20m (was: 2h 10m)
> Futurize and fix python 2 compatibility for internal subpackage
> ---------------------------------------------------------------
>
> Key: BEAM-3999
> URL: https://issues.apache.org/jira/browse/BEAM-3999
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
