[
https://issues.apache.org/jira/browse/BEAM-3883?focusedWorklogId=104779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104779
]
ASF GitHub Bot logged work on BEAM-3883:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/18 20:46
Start Date: 22/May/18 20:46
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5273:
[BEAM-3883] Adding Client to push artifacts to artifact staging service
URL: https://github.com/apache/beam/pull/5273#discussion_r190047124
##########
File path: sdks/python/apache_beam/runners/portability/portable_stager_test.py
##########
@@ -48,7 +48,10 @@ def tearDown(self):
if self._remote_dir:
shutil.rmtree(self._remote_dir)
- def stage_files(self, files):
+ def _stage_files(self, files):
+ """
Review comment:
The reason I asked for docstring is that it would be useful to describe the
structure of `files` since it is not obvious without reading the method. How
about:
```
Utility method to stage files.
Args:
files: a list of tuples of the form [(local_name, remote_name),...]
describing the name of the artifacts in local temp folder and desired name in
staging location.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 104779)
Time Spent: 18h 40m (was: 18.5h)
> Python SDK stages artifacts when talking to job server
> ------------------------------------------------------
>
> Key: BEAM-3883
> URL: https://issues.apache.org/jira/browse/BEAM-3883
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ben Sidhom
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 18h 40m
> Remaining Estimate: 0h
>
> The Python SDK does not currently stage its user-defined functions or
> dependencies when talking to the job API. Artifacts that need to be staged
> include the user code itself, any SDK components not included in the
> container image, and the list of Python packages that must be installed at
> runtime.
>
> Artifacts that are currently expected can be found in the harness boot code:
> [https://github.com/apache/beam/blob/58e3b06bee7378d2d8db1c8dd534b415864f63e1/sdks/python/container/boot.go#L52.]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
