Kenneth Knowles created BEAM-4394:
-------------------------------------

             Summary: Consider enabling spotless java format throughout codebase
                 Key: BEAM-4394
                 URL: https://issues.apache.org/jira/browse/BEAM-4394
             Project: Beam
          Issue Type: New Feature
          Components: build-system
            Reporter: Kenneth Knowles


"Spotless" can enforce - and automatically restore - automatic Java formatting. 
Whenever formatting is off, it tells a user the exact command to fix it.

It isn't (just) about code layout, it is about automation. We have pretty 
strict style rules enforced by checkstyle. The most efficient way to fix up a 
file is with autoformat. But if the autoformat hits a bunch of irrelevant 
lines, that is annoying for a reviewer and obscures git blame.

If we enforce autoformat all the time, then it makes sure that autoformatting a 
particular PR has minimal effects and is always safe to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to