[
https://issues.apache.org/jira/browse/BEAM-4008?focusedWorklogId=105397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105397
]
ASF GitHub Bot logged work on BEAM-4008:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/18 23:00
Start Date: 23/May/18 23:00
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5336:
[BEAM-4008] Futurize utils subpackage
URL: https://github.com/apache/beam/pull/5336#discussion_r190419324
##########
File path: sdks/python/apache_beam/utils/timestamp.py
##########
@@ -143,11 +148,35 @@ def __int__(self):
# Note that the returned value may have lost precision.
return self.micros // 1000000
- def __cmp__(self, other):
- # Allow comparisons between Duration and Timestamp values.
+ def __eq__(self, other):
Review comment:
How about we keep `__eq__` and `__lt__`, remove the rest and decorate the
class with `@functools.total_ordering`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 105397)
Time Spent: 1h (was: 50m)
> Futurize and fix python 2 compatibility for utils subpackage
> ------------------------------------------------------------
>
> Key: BEAM-4008
> URL: https://issues.apache.org/jira/browse/BEAM-4008
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
