[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105734
]
ASF GitHub Bot logged work on BEAM-4393:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/18 21:35
Start Date: 24/May/18 21:35
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5472: [BEAM-4393]: Copy
root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472#issuecomment-391870562
I believe we run the jar rule to build a jar with only our code, then we run
the shadowJar rule to bundle that jar with third party code. This only needs to
be in shadowJar, but that leaves our code in jar without a LICENSE file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 105734)
Time Spent: 1h 10m (was: 1h)
> Missing copyright notices for shaded packages
> ---------------------------------------------
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
> Reporter: Scott Wegner
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
