[ https://issues.apache.org/jira/browse/BEAM-4145?focusedWorklogId=106030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106030 ]
ASF GitHub Bot logged work on BEAM-4145: ---------------------------------------- Author: ASF GitHub Bot Created on: 25/May/18 21:59 Start Date: 25/May/18 21:59 Worklog Time Spent: 10m Work Description: angoenka commented on a change in pull request #5456: [BEAM-4145] Populate the worker_id metadata in the Java SDK Harness URL: https://github.com/apache/beam/pull/5456#discussion_r191010767 ########## File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/channel/ManagedChannelFactory.java ########## @@ -41,7 +42,24 @@ public static ManagedChannelFactory createEpoll() { return new Epoll(); } - public abstract ManagedChannel forDescriptor(ApiServiceDescriptor apiServiceDescriptor); + public final ManagedChannel forDescriptor(ApiServiceDescriptor apiServiceDescriptor) { + return forDescriptorOnly(apiServiceDescriptor); Review comment: Shall we get away with this indirection? Implementer can always overwrite this public method (if we drop the final). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 106030) Time Spent: 1h (was: 50m) > Java SDK Harness populates control request headers with worker id > ----------------------------------------------------------------- > > Key: BEAM-4145 > URL: https://issues.apache.org/jira/browse/BEAM-4145 > Project: Beam > Issue Type: New Feature > Components: sdk-java-harness > Reporter: Ben Sidhom > Assignee: Thomas Groh > Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > Runner code needs to be able to identify incoming harness connections by the > worker ids that it assigns to them on creation. This is currently done by the > go boot code when the harness runs in a docker container. However, in-process > harnesses never specify worker ids. This prevents in-process harnesses from > being multiplexed by a runner (most likely the ULR and test code). -- This message was sent by Atlassian JIRA (v7.6.3#76005)