[
https://issues.apache.org/jira/browse/BEAM-4145?focusedWorklogId=106086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106086
]
ASF GitHub Bot logged work on BEAM-4145:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/18 00:57
Start Date: 26/May/18 00:57
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #5456:
[BEAM-4145] Populate the worker_id metadata in the Java SDK Harness
URL: https://github.com/apache/beam/pull/5456#discussion_r191034902
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##########
@@ -115,43 +124,46 @@ public static void main(PipelineOptions options,
}
public static void main(
+ String id,
PipelineOptions options,
Endpoints.ApiServiceDescriptor loggingApiServiceDescriptor,
Endpoints.ApiServiceDescriptor controlApiServiceDescriptor,
ManagedChannelFactory channelFactory,
StreamObserverFactory streamObserverFactory) {
IdGenerator idGenerator = IdGenerators.decrementingLongs();
- try (BeamFnLoggingClient logging = new BeamFnLoggingClient(
- options,
- loggingApiServiceDescriptor,
- channelFactory::forDescriptor)) {
+ try (BeamFnLoggingClient logging =
Review comment:
No. This is done to close the client automatically at the completion of the
`try` block, and the client must exist to send intercepted LOG messages to the
logging server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 106086)
Time Spent: 2h 20m (was: 2h 10m)
> Java SDK Harness populates control request headers with worker id
> -----------------------------------------------------------------
>
> Key: BEAM-4145
> URL: https://issues.apache.org/jira/browse/BEAM-4145
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness
> Reporter: Ben Sidhom
> Assignee: Thomas Groh
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Runner code needs to be able to identify incoming harness connections by the
> worker ids that it assigns to them on creation. This is currently done by the
> go boot code when the harness runs in a docker container. However, in-process
> harnesses never specify worker ids. This prevents in-process harnesses from
> being multiplexed by a runner (most likely the ULR and test code).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
