[ https://issues.apache.org/jira/browse/BEAM-4276?focusedWorklogId=106927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106927 ]
ASF GitHub Bot logged work on BEAM-4276: ---------------------------------------- Author: ASF GitHub Bot Created on: 29/May/18 23:18 Start Date: 29/May/18 23:18 Worklog Time Spent: 10m Work Description: lostluck opened a new pull request #5507: Robert Burke Robert Burke [BEAM-4276] Add combiner lifting support to Go SDK URL: https://github.com/apache/beam/pull/5507 Implements combiner lifting support to the Go SDK, for universal runners. Per https://s.apache.org/beam-runner-api-combine-model, the Go SDK puts the URN and CombinePayload on the composite containing the basic unlifted combine implementation for runners which don't support the optimization. There are a few TODOs but I can lift them into JIRAs as necessary. Of note is that the current go implementation for Top uses an unencodable accumulator type (it contains []interface{}) so it is unable to be lifted at present. However, when this case is detected, the SDK will simply not add the URN and payload and continue with it's existing representation as a vanilla ParDo to runners. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 106927) Time Spent: 2h 10m (was: 2h) > Implement the portable lifted Combiner transforms in Go SDK > ----------------------------------------------------------- > > Key: BEAM-4276 > URL: https://issues.apache.org/jira/browse/BEAM-4276 > Project: Beam > Issue Type: Sub-task > Components: sdk-go > Reporter: Henning Rohde > Assignee: Robert Burke > Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)