[
https://issues.apache.org/jira/browse/BEAM-4290?focusedWorklogId=106967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106967
]
ASF GitHub Bot logged work on BEAM-4290:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/18 01:24
Start Date: 30/May/18 01:24
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #5489:
[BEAM-4290] proto changes to support artifact_staging_id
URL: https://github.com/apache/beam/pull/5489#discussion_r191617046
##########
File path: model/job-management/src/main/proto/beam_job_api.proto
##########
@@ -69,12 +69,16 @@ message PrepareJobRequest {
message PrepareJobResponse {
// (required) The ID used to associate calls made while preparing the job.
preparationId is used
- // to run the job, as well as in other pre-execution APIs such as Artifact
staging.
+ // to run the job.
string preparation_id = 1;
// An endpoint which exposes the Beam Artifact Staging API. Artifacts used
by the job should be
// staged to this endpoint, and will be available during job execution.
org.apache.beam.model.pipeline.v1.ApiServiceDescriptor
artifact_staging_endpoint = 2;
Review comment:
@lukecwik suggested in a separate PR to add a client_id to the
ApiServiceDescriptor proto and always send that as a header. Would that ID be
suitable for an artifact_staging_id separate from preparation_id? Then no other
changes would be needed (except fixing the comment above) and the propagation
would be done by general purpose logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 106967)
Time Spent: 2h 10m (was: 2h)
> ArtifactStagingService that stages to a distributed filesystem
> --------------------------------------------------------------
>
> Key: BEAM-4290
> URL: https://issues.apache.org/jira/browse/BEAM-4290
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Using the job's staging directory from PipelineOptions.
> Physical layout on the distributed filesystem is TBD but it should allow for
> arbitrary filenames and ideally for eventually avoiding uploading artifacts
> that are already there.
> Handling credentials is TBD.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
