[ https://issues.apache.org/jira/browse/BEAM-4283?focusedWorklogId=107626&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107626 ]
ASF GitHub Bot logged work on BEAM-4283: ---------------------------------------- Author: ASF GitHub Bot Created on: 31/May/18 09:50 Start Date: 31/May/18 09:50 Worklog Time Spent: 10m Work Description: echauchot commented on a change in pull request #5464: [BEAM-4283] Write Nexmark execution times to bigquery URL: https://github.com/apache/beam/pull/5464#discussion_r192045764 ########## File path: sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkConfiguration.java ########## @@ -420,6 +428,9 @@ public String toShortString() { if (sinkType != DEFAULT.sinkType) { sb.append(String.format("; sinkType:%s", sinkType)); } + if (exportSummaryToBigQuery != DEFAULT.exportSummaryToBigQuery) { Review comment: Like all the other configuration items, when we print the configuration, we print their value only if they are set by the user (i.e. their value is not the default value) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 107626) Time Spent: 1h 50m (was: 1h 40m) > Export nexmark execution times to bigQuery > ------------------------------------------ > > Key: BEAM-4283 > URL: https://issues.apache.org/jira/browse/BEAM-4283 > Project: Beam > Issue Type: Sub-task > Components: examples-nexmark > Reporter: Etienne Chauchot > Assignee: Etienne Chauchot > Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Nexmark only outputs the results collection to bigQuery and prints in the > console the execution times. To supervise Nexmark execution times, we need to > store them as well per runner/query/mode -- This message was sent by Atlassian JIRA (v7.6.3#76005)