[
https://issues.apache.org/jira/browse/BEAM-4290?focusedWorklogId=107877&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107877
]
ASF GitHub Bot logged work on BEAM-4290:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/18 20:49
Start Date: 31/May/18 20:49
Worklog Time Spent: 10m
Work Description: jkff commented on a change in pull request #5489:
[BEAM-4290] proto changes to support artifact_staging_id
URL: https://github.com/apache/beam/pull/5489#discussion_r192168198
##########
File path: model/job-management/src/main/proto/beam_artifact_api.proto
##########
@@ -102,13 +99,19 @@ message ArtifactChunk {
bytes data = 1;
}
+message PutArtifactMetadata {
+ // (Required) An identifier for artifact staging session.
+ string artifact_staging_id = 1;
+ // (Required) The Artifact metadata.
+ ArtifactMetadata metadata = 2;
+}
+
// A request to stage an artifact.
message PutArtifactRequest {
// (Required)
oneof content {
- // The Artifact metadata. The first message in a PutArtifact call must
contain the name
- // of the artifact.
- ArtifactMetadata metadata = 1;
+ // The first message in a PutArtifact call must contain this field.
Review comment:
Any reason not to put the staging session token as a top-level field in
PutArtifactRequest, instead of adding the new message PutArtifactMetadata? The
latter feels confusing since the session token is not really associated with
any particular artifact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 107877)
Time Spent: 4h 10m (was: 4h)
> ArtifactStagingService that stages to a distributed filesystem
> --------------------------------------------------------------
>
> Key: BEAM-4290
> URL: https://issues.apache.org/jira/browse/BEAM-4290
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Using the job's staging directory from PipelineOptions.
> Physical layout on the distributed filesystem is TBD but it should allow for
> arbitrary filenames and ideally for eventually avoiding uploading artifacts
> that are already there.
> Handling credentials is TBD.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
