[
https://issues.apache.org/jira/browse/BEAM-2915?focusedWorklogId=107980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107980
]
ASF GitHub Bot logged work on BEAM-2915:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/18 04:54
Start Date: 01/Jun/18 04:54
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #5445:
[BEAM-2915] Add support for handling bag user state to the java-fn-execution
library to support runner integration.
URL: https://github.com/apache/beam/pull/5445#discussion_r192297971
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/GreedyPCollectionFusers.java
##########
@@ -181,6 +181,10 @@ private static boolean parDoCompatibility(
// side inputs can be fused with other transforms in the same environment
which are not
// upstream of any of the side inputs.
return pipeline.getSideInputs(parDo).isEmpty()
+ // Since we lack the ability to mark upstream transforms as key
preserving, we
+ // purposefully break fusion here to provide runners the opportunity
to insert a
+ // grouping operation
+ && pipeline.getUserStates(parDo).isEmpty()
Review comment:
Based on what information would a runner insert a shuffle though? Unless
that is available, there is also no benefit breaking the chain here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 107980)
Time Spent: 0.5h (was: 20m)
> Java SDK support for portable user state
> ----------------------------------------
>
> Key: BEAM-2915
> URL: https://issues.apache.org/jira/browse/BEAM-2915
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Henning Rohde
> Assignee: Luke Cwik
> Priority: Minor
> Labels: portability
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
