[ https://issues.apache.org/jira/browse/BEAM-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ismaël Mejía resolved BEAM-4310. -------------------------------- Resolution: Fixed Fix Version/s: 2.5.0 > Enforce ErrorProne analysis in runners-extensions-java-metrics project > ---------------------------------------------------------------------- > > Key: BEAM-4310 > URL: https://issues.apache.org/jira/browse/BEAM-4310 > Project: Beam > Issue Type: Improvement > Components: runner-extensions-metrics > Reporter: Scott Wegner > Assignee: Ismaël Mejía > Priority: Minor > Labels: errorprone, starter > Fix For: 2.5.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Java ErrorProne static analysis was [recently > enabled|https://github.com/apache/beam/pull/5161] in the Gradle build > process, but only as warnings. ErrorProne errors are generally useful and > easy to fix. Some work was done to [make sdks-java-core > ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add > enforcement. This task is clean ErrorProne warnings and add enforcement in > {{beam-runners-extensions-java-metrics}}. Additional context discussed on the > [dev > list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E]. > Fixing this issue will involve: > # Follow instructions in the [Contribution > Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development > environment. > # Run the following command to compile and run ErrorProne analysis on the > project: {{./gradlew :beam-runners-extensions-java-metrics:assemble}} > # Fix each ErrorProne warning from the {{runners/extensions-java/metrics}} > project. > # In {{runners/extensions-java/metrics/build.gradle}}, add {{failOnWarning: > true}} to the call the {{applyJavaNature()}} > ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]). > This starter issue is sponsored by [~swegner]. Feel free to [reach > out|https://beam.apache.org/community/contact-us/] with questions or code > review: > * JIRA: [~swegner] > * GitHub: [@swegner|https://github.com/swegner] > * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel] > * Email: swegner at google dot com -- This message was sent by Atlassian JIRA (v7.6.3#76005)