[ 
https://issues.apache.org/jira/browse/BEAM-4519?focusedWorklogId=109992&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-109992
 ]

ASF GitHub Bot logged work on BEAM-4519:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jun/18 03:54
            Start Date: 08/Jun/18 03:54
    Worklog Time Spent: 10m 
      Work Description: axelmagn commented on a change in pull request #5582: 
[BEAM-4519] Add staging_token to GetManifestRequest
URL: https://github.com/apache/beam/pull/5582#discussion_r193947173
 
 

 ##########
 File path: model/job-management/src/main/proto/beam_artifact_api.proto
 ##########
 @@ -81,7 +81,11 @@ message ProxyManifest {
 }
 
 // A request to get the manifest of a Job.
-message GetManifestRequest {}
+message GetManifestRequest {
+  // (Required) An opaque token representing the entirety of the staged 
artifacts.
 
 Review comment:
   I missed this comment in my fixup, but I agree that now is a good time to 
rename this field.  Fixed and documented.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 109992)
    Time Spent: 1h 20m  (was: 1h 10m)

> Artifact Retrieval Service Protocol should be able to serve multiple 
> Manifests.
> -------------------------------------------------------------------------------
>
>                 Key: BEAM-4519
>                 URL: https://issues.apache.org/jira/browse/BEAM-4519
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Axel Magnuson
>            Assignee: Axel Magnuson
>            Priority: Minor
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The artifact staging service currently returns a staging_token that can be 
> used as a key to access a manifest.  However, the current protocol does not 
> have a field that accepts this token.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to