[
https://issues.apache.org/jira/browse/BEAM-2281?focusedWorklogId=110376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110376
]
ASF GitHub Bot logged work on BEAM-2281:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/18 04:10
Start Date: 09/Jun/18 04:10
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #5596:
[BEAM-2281] Improve SQL expression testing so SQL syntax tests suffice; delete
extraneous unit tests
URL: https://github.com/apache/beam/pull/5596
Previously, we had unit tests because we implemented a lot of standard
functions from scratch. Now we use Calcite's implementations and we don't need
tests for them. We need some smoke tests that we have plumbed things correctly.
The SQL syntax tests are more more concise and work well for that (and actually
for all purposes).
To make this feasible, the base testing infrastructure needed a tweak to
give more informative errors, by having separate asserts for each test case.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 110376)
Time Spent: 1h 50m (was: 1h 40m)
> call SqlFunctions in operator implementation
> --------------------------------------------
>
> Key: BEAM-2281
> URL: https://issues.apache.org/jira/browse/BEAM-2281
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Calcite has a collections of functions in
> {{org.apache.calcite.runtime.SqlFunctions}}. It sounds a good source to
> leverage when adding operators as {{BeamSqlExpression}}.
> [~xumingming] [~app-tarush], any comments?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
