[
https://issues.apache.org/jira/browse/BEAM-4526?focusedWorklogId=111107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111107
]
ASF GitHub Bot logged work on BEAM-4526:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/18 16:19
Start Date: 12/Jun/18 16:19
Worklog Time Spent: 10m
Work Description: bsidhom commented on issue #5597: [BEAM-4526] Suppress
immutability warning caused by LoadingCache in enum instance
URL: https://github.com/apache/beam/pull/5597#issuecomment-396649447
Thanks for fixing this. I'm not sure why you think this is trying to be too
clever though. Using a single-element enum is recommended by Effective Java
Item 3. Beyond the standard static field approach, this also ensures
singleton-ness even in the face of (de-)serialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 111107)
Time Spent: 50m (was: 40m)
> FlinkRunner failing errorprone due to mutable enum
> --------------------------------------------------
>
> Key: BEAM-4526
> URL: https://issues.apache.org/jira/browse/BEAM-4526
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Blocker
> Fix For: 2.6.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code}
> runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/BatchFlinkExecutableStageContext.java:77:
> warning: [ImmutableEnumChecker] enums should be immutable: 'BatchFactory'
> has field 'cachedContexts' of type
> 'com.google.common.cache.LoadingCache<org.apache.beam.runners.fnexecution.provisioning.JobInfo,org.apache.beam.runners.flink.translation.functions.BatchFlinkExecutableStageContext>',
> the declaration of type
> 'com.google.common.cache.LoadingCache<org.apache.beam.runners.fnexecution.provisioning.JobInfo,org.apache.beam.runners.flink.translation.functions.BatchFlinkExecutableStageContext>'
> is not annotated with @com.google.errorprone.annotations.Immutable or
> @javax.annotation.concurrent.Immutable
> private final LoadingCache<JobInfo, BatchFlinkExecutableStageContext>
> cachedContexts;
> ^
> (see http://errorprone.info/bugpattern/ImmutableEnumChecker)
> error: warnings found and -Werror specified
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
