[
https://issues.apache.org/jira/browse/BEAM-4533?focusedWorklogId=111140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111140
]
ASF GitHub Bot logged work on BEAM-4533:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/18 17:11
Start Date: 12/Jun/18 17:11
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #5601:
[BEAM-4533] [SQL] Support unquoted table types
URL: https://github.com/apache/beam/pull/5601#discussion_r194819304
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/parser/SqlCreateTable.java
##########
@@ -148,8 +149,14 @@ private void unparseColumn(SqlWriter writer, Schema.Field
column) {
}
}
- private String getString(SqlNode n) {
- return n == null ? null : ((NlsString) SqlLiteral.value(n)).getValue();
+ private @Nullable String getString(SqlNode n) {
+ if (n == null) {
+ return null;
+ }
+ if (n instanceof SqlIdentifier) {
+ return ((SqlIdentifier) n).toString();
Review comment:
My understanding is that this part does not change casing. I know that we
change field names to lower case, but we do it explicitly in a [different
place](https://github.com/apache/beam/blob/d506e1ef8968bf97432b522bf8589db4f1be29f6/sdks/java/extensions/sql/src/main/codegen/includes/parserImpls.ftl#L115).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 111140)
Time Spent: 1h 50m (was: 1h 40m)
> Beam SQL should support unquoted types
> --------------------------------------
>
> Key: BEAM-4533
> URL: https://issues.apache.org/jira/browse/BEAM-4533
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> TYPE text in addition to TYPE 'text'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
