[
https://issues.apache.org/jira/browse/BEAM-4050?focusedWorklogId=111199&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111199
]
ASF GitHub Bot logged work on BEAM-4050:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/18 18:38
Start Date: 12/Jun/18 18:38
Worklog Time Spent: 10m
Work Description: swegner opened a new pull request #5608: [BEAM-4050]
Use new DSL methods for generated POM metadata
URL: https://github.com/apache/beam/pull/5608
POM generation APIs were improved in Gradle 4.8; this change takes
advantage of new DSL APIs to define generated POM metadata when
available. Some metadata (notably dependencies) still need to be
directly added to the XML.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 111199)
Time Spent: 10m
Remaining Estimate: 0h
> Move pom generation metadata logic out of build_rules.gradle
> ------------------------------------------------------------
>
> Key: BEAM-4050
> URL: https://issues.apache.org/jira/browse/BEAM-4050
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Scott Wegner
> Assignee: Luke Cwik
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When preparing a release, we generate pom files for each artifact to be
> released. Most of the pom structure is filled in automatically, but there is
> a good deal of metadata that needs to be manually added. The [code for
> manipulating the XML
> structure|https://github.com/apache/beam/blob/c78b96a67c0313f44d78262ee46f86aa4866a3aa/build_rules.gradle#L605]
> is verbose and it would make more sense to actually express it as XML rather
> than groovy DOM manipulations.
> It would be nice to refactor this and clean up the build_rules.gradle file a
> bit. Some potential ideas for refactoring:
> # Check in a "base pom.xml" file pre-filled with metadata, and use this as
> the source for generated pom manipulations.
> # Check in and release a parent pom file which contains all required
> metadata. Other artifacts can reference it as a parent and then drop the
> duplicated metadata.
> # At the very least, refactor the pom manipulation logic out to a different
> method or different file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
