[
https://issues.apache.org/jira/browse/BEAM-4276?focusedWorklogId=111350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111350
]
ASF GitHub Bot logged work on BEAM-4276:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/18 23:48
Start Date: 12/Jun/18 23:48
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #5620:
[BEAM-4276] Surface graph.Fn encoding functions.
URL: https://github.com/apache/beam/pull/5620#discussion_r194921365
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/user.go
##########
@@ -80,6 +81,28 @@ func DecodeFn(data string) (reflectx.Func, error) {
return fn.Fn, nil
}
+// EncodeGraphFn encodes a *graph.Fn as a string.
+func EncodeGraphFn(u *graph.Fn) (string, error) {
Review comment:
It's related to Combiner Lifting, so I've used that jira tag.
Since it can help with writing a bundle level precombine, using existing
combineFns, which is what I'm using it for at present, since the beam model/SDK
doesn't yet support lifting combines through a CoGroupByKey. That's the root of
it anyway. I like thinking of it as enabling the writing of MetaStructs.
The main goal is for me to avoid needing to write my precombine helper one
way now and then re-writing later when there is official support for such a
thing. If that feature does show up, I can simply use the same CombineFns over
again.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 111350)
Time Spent: 8h 20m (was: 8h 10m)
> Implement the portable lifted Combiner transforms in Go SDK
> -----------------------------------------------------------
>
> Key: BEAM-4276
> URL: https://issues.apache.org/jira/browse/BEAM-4276
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Specifically add the necessary code to produce a Combine Composite with the
> correct URN, and permit the SDK harness to understand the lifted parts when
> receiving a bundle plan from the worker.
> Not expected as part of this issue is:
> Additional performance tweaks to the in memory cache (See
> [BEAM-4468|https://issues.apache.org/jira/browse/BEAM-4468])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
