[
https://issues.apache.org/jira/browse/BEAM-4327?focusedWorklogId=112292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112292
]
ASF GitHub Bot logged work on BEAM-4327:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/18 11:06
Start Date: 15/Jun/18 11:06
Worklog Time Spent: 10m
Work Description: timrobertson100 commented on issue #5647: [BEAM-4327]
Fix ErrorProne violations in fn-harness
URL: https://github.com/apache/beam/pull/5647#issuecomment-397588526
Looks good @swegner - thanks
2 small suggestions for inline comment and can you rebase please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 112292)
Time Spent: 1h (was: 50m)
> Enforce ErrorProne analysis in the java harness project
> -------------------------------------------------------
>
> Key: BEAM-4327
> URL: https://issues.apache.org/jira/browse/BEAM-4327
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Minor
> Labels: errorprone, starter
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-sdks-java-harness}}. Additional context discussed on the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-sdks-java-harness:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/harness}} project.
> # In {{sdks/java/harness/build.gradle}}, add {{failOnWarning: true}} to the
> call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
