[
https://issues.apache.org/jira/browse/BEAM-4225?focusedWorklogId=113197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113197
]
ASF GitHub Bot logged work on BEAM-4225:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/18 14:53
Start Date: 19/Jun/18 14:53
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #4976:
[BEAM-4225] Add Nexmark PostCommit runs for spark, flink and direct runner and
export to Bigquery
URL: https://github.com/apache/beam/pull/4976#discussion_r196457727
##########
File path: .test-infra/jenkins/job_beam_PostCommit_Java_Nexmark_Direct.groovy
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import common_job_properties
+
+// This job runs the suite of ValidatesRunner tests against the Direct runner.
+job('beam_PostCommit_Java_Nexmark_Direct') {
+ description('Runs the Nexmark suite on the Direct runner.')
+
+ // Set common parameters.
+ common_job_properties.setTopLevelMainJobProperties(delegate, 'master', 240)
+
+ // Sets that this is a PostCommit job.
+ common_job_properties.setPostCommit(delegate)
+
+ // Allows triggering this build against pull requests.
+ common_job_properties.enablePhraseTriggeringFromPullRequest(
+ delegate,
+ 'Apache Direct Runner Nexmark Tests',
+ 'Run Direct Nexmark')
+
+ // Gradle goals for this job.
+ steps {
+ shell('echo *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER ***')
+ gradle {
+ rootBuildScriptDir(common_job_properties.checkoutDir)
+ tasks(':beam-sdks-java-nexmark:run')
+ common_job_properties.setGradleSwitches(delegate)
+ switches('-Pnexmark.runner=":beam-runners-direct-java"' +
+ ' -Pnexmark.args="' +
+ ' --bigQueryTable=nexmark\n'+
+ ' --bigQueryDataset=nexmark\n'+
+ ' --project=apache-beam-testing\n'+
+ ' --resourceNameMode=QUERY_RUNNER_AND_MODE\n'+
+ ' --exportSummaryToBigQuery=true\n'+
Review comment:
This in effect will cause that "phrase triggered" runs' results (from PR's
branch) and periodic runs' results (from master) will get mixed in the same
BigQuery table. If I'm not wrong (please correct me if I am), we should not
keep the results from Phrase triggered jobs in the table (so for such jobs
`exportSummaryToBigQuery` should be false). This is the same problem that we
have in Performance tests. Unfortunately, it was not addressed yet. See
[here](https://issues.apache.org/jira/browse/BEAM-4298) for more context if
you're interested.
I'm leaning to splitting the jobs to separate ones, as Kenneth suggests.
What is more, you can even place all the job definitions in one .groovy file,
see
[job_PerformanceTests_FileBasedIO_IT.groovy](https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_PerformanceTests_FileBasedIO_IT.groovy)
as an example on how to define jobs parametrized way. Not only this fixes the
the problem but is also concise. Alternatively, we can skip this for now but
create a JIRA for later.
WDYT @echauchot (& @kennknowles )?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 113197)
Time Spent: 1.5h (was: 1h 20m)
> Integrate Nexmark with perfkit dashboards
> -----------------------------------------
>
> Key: BEAM-4225
> URL: https://issues.apache.org/jira/browse/BEAM-4225
> Project: Beam
> Issue Type: Improvement
> Components: examples-nexmark
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The aim is to run Nexmark as post-commits and export the results to the
> performance dashboards:
> see the threads:
> [https://lists.apache.org/thread.html/9f8fe1c6df7d8bfe2697332e69722ca4edd2810adc6a914cdf32da29@%3Cdev.beam.apache.org%3E]
> https://lists.apache.org/thread.html/701196efd6e74b7715785d43019a4a73e8a093997f59662fdadf8f2a@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
