[
https://issues.apache.org/jira/browse/BEAM-4291?focusedWorklogId=113357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113357
]
ASF GitHub Bot logged work on BEAM-4291:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/18 20:29
Start Date: 19/Jun/18 20:29
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #5676:
[BEAM-4291] Propagates artifact retrieval token in Flink runner and to the Java
harness
URL: https://github.com/apache/beam/pull/5676#discussion_r196552574
##########
File path: model/fn-execution/src/main/proto/beam_provision_api.proto
##########
@@ -67,6 +67,10 @@ message ProvisionInfo {
// (optional) Resource limits that the SDK harness worker should respect.
// Runners may -- but are not required to -- enforce any limits provided.
Resources resource_limits = 4;
+
+ // (required) The artifact retrieval token produced by
+ // ArtifactStagingService.CommitManifestResponse.
+ string retrieval_token = 6;
Review comment:
High-level comment: What will we be using this token for, concretely? We
already have the client ID to tell SDK harnesses apart. I don't recall it being
discussed in the design doc.
It also seems somewhat out of place to include a retrieval_token here, but
not the ApiServiceDescriptor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 113357)
Time Spent: 6h 40m (was: 6.5h)
> ArtifactRetrievalService that retrieves artifacts from a distributed
> filesystem
> -------------------------------------------------------------------------------
>
> Key: BEAM-4291
> URL: https://issues.apache.org/jira/browse/BEAM-4291
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Axel Magnuson
> Priority: Major
> Fix For: 2.6.0
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> In agreement with how they are staged in BEAM-4290.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
