[
https://issues.apache.org/jira/browse/BEAM-4325?focusedWorklogId=113426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113426
]
ASF GitHub Bot logged work on BEAM-4325:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/18 23:02
Start Date: 19/Jun/18 23:02
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #5669:
[BEAM-4325] Enforce ErrorProne analysis in the SQL project
URL: https://github.com/apache/beam/pull/5669#discussion_r196605063
##########
File path: build_rules.gradle
##########
@@ -418,7 +418,7 @@ ext.applyJavaNature = {
targetCompatibility = configuration.javaVersion
tasks.withType(JavaCompile) {
options.encoding = "UTF-8"
- options.compilerArgs +=
["-Xlint:all","-Xlint:-options","-Xlint:-cast","-Xlint:-deprecation","-Xlint:-processing","-Xlint:-rawtypes","-Xlint:-serial","-Xlint:-try","-Xlint:-unchecked","-Xlint:-varargs","-parameters"]
+ options.compilerArgs +=
["-Xlint:all","-Xlint:-options","-Xlint:-cast","-Xlint:-deprecation","-Xlint:-dep-ann","-Xlint:-processing","-Xlint:-rawtypes","-Xlint:-serial","-Xlint:-try","-Xlint:-unchecked","-Xlint:-varargs","-parameters"]
Review comment:
Sorry for the slow response. I pulled your branch to investigate this a bit
more. It seems that we are using a very old version of the javacc tool, and
more recent versions don't have this issue.
https://github.com/cademarkegard/beam/pull/1 fixes it, but we should
double-check with SQL contributors to ensure this won't break anything. /cc
@apilloud @kennknowles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 113426)
Time Spent: 1h 40m (was: 1.5h)
> Enforce ErrorProne analysis in the SQL project
> ----------------------------------------------
>
> Key: BEAM-4325
> URL: https://issues.apache.org/jira/browse/BEAM-4325
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Scott Wegner
> Assignee: Cade Markegard
> Priority: Minor
> Labels: errorprone, starter
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-sdks-java-extensions-sql}}. Additional context discussed on the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-sdks-java-extensions-sql:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/extensions/sql}} project.
> # In {{sdks/java/extensions/sql/build.gradle}}, add {{failOnWarning: true}}
> to the call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
