[
https://issues.apache.org/jira/browse/BEAM-3708?focusedWorklogId=113971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113971
]
ASF GitHub Bot logged work on BEAM-3708:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/18 23:24
Start Date: 20/Jun/18 23:24
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5622:
[BEAM-3708] Adding Combine component implementations to Java SDK
URL: https://github.com/apache/beam/pull/5622#discussion_r196971687
##########
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FlattenRunnerTest.java
##########
@@ -109,7 +109,7 @@ public void testCreatingAndProcessingDoFlatten() throws
Exception {
}
/**
- * Create a Flatten that has 4 inputs (inputATarget1, inputATarget2,
inputBTarget, inputCTarget)
+ * Create a Flatten that has 4 inputs (inputATarget1, inputATarget1,
inputATarget2, inputATarget2)
Review comment:
This flatten only has two inputs (`inputA`, `inputAAgain`) and not 4.
Listing them isn't important to the test so consider saying this test consumes
data from the same PCollection.
Also, on line 158, consider using MultiplexingFnDataReceiver.forConsumers to
have a single target instead of invoking each target separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 113971)
Time Spent: 50m (was: 40m)
> Implement the portable lifted Combiner transforms in Java SDK
> -------------------------------------------------------------
>
> Key: BEAM-3708
> URL: https://issues.apache.org/jira/browse/BEAM-3708
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core, sdk-java-harness
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Labels: portability
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Lifted combines are split into separate parts with different URNs. These
> parts need to be implemented in the Java SDK harness so that the SDK can
> actually execute them when receiving Combine transforms with the
> corresponding URNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
